check codespell & fixing some... #2103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems ignore does not work properly - codespell-project/codespell#2839 (comment) - RESOLVED |
github-actions
bot
added
documentation
for more information, see https://pre-commit.ci
|
@lucadiliello, all good points; mind adding them as suggestions so they are easier to accept? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2103 +/- ##
======================================
Coverage 87% 87%
======================================
Files 293 293
Lines 16299 16299
======================================
Hits 14177 14177
Misses 2122 2122 |
SkafteNicki
reviewed
Sep 25, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
awaelchli
approved these changes
Sep 25, 2023
SkafteNicki
approved these changes
Sep 26, 2023
Borda
added a commit
that referenced
this pull request
Nov 30, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Di Liello <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 64f17f0)
Borda
added a commit
that referenced
this pull request
Dec 1, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Luca Di Liello <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 64f17f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixing typos and preventing adding new...
Closes #2102 because of #2102 (comment)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2103.org.readthedocs.build/en/2103/